The Wayback Machine - https://web.archive.org/web/20200916132739/https://github.com/TheAlgorithms/C/pull/590
Skip to content

/ C

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Absolute Value #590

Open
wants to merge 2 commits into
base: master
from
Open

Add Absolute Value #590

wants to merge 2 commits into from

Conversation

@shellhub
Copy link
Member

shellhub commented Aug 6, 2020 •
edited by gitpod-io bot

Description of Change

absolute value

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

shellhub and others added 2 commits Aug 6, 2020
@shellhub
absolute value
7922514
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
a51655e
@shellhub shellhub requested a review from kvedala Aug 6, 2020
@swapnanildutta
swapnanildutta approved these changes Aug 6, 2020
View changes
@swapnanildutta
swapnanildutta approved these changes Aug 6, 2020
View changes
@shellhub
Copy link
Member Author

shellhub commented Aug 7, 2020

@kvedala Please review.
@kvedala
Copy link
Collaborator

kvedala commented Aug 7, 2020

I don't think this really is an algorithm, don't you? 🤔
@shellhub
Copy link
Member Author

shellhub commented Aug 8, 2020

Other repositories in TheAlgorithm has similar math functions @kvedala
@shellhub
Copy link
Member Author

shellhub commented Aug 8, 2020

I think maths folder is needed in this repository
@kvedala
Copy link
Collaborator

kvedala commented Aug 8, 2020

I think maths folder is needed in this repository

Thats ok, but the contribution here - the absolute value - is not really algorithm, is it?
@shellhub
Copy link
Member Author

shellhub commented Aug 8, 2020 •
edited

Should we keep same with Python version ？ See https://github.com/TheAlgorithms/Python/blob/master/maths/abs.py @kvedala
@kvedala
Copy link
Collaborator

kvedala commented Aug 8, 2020

Should we keep same with Python version ？ See https://github.com/TheAlgorithms/Python/blob/master/maths/abs.py @kvedala

There are a lot of more advanced pure math-algorithms in the misc folder. I'll wait for other admins to pitch in.
@shellhub shellhub closed this Aug 8, 2020
@kvedala
Copy link
Collaborator

kvedala commented Aug 8, 2020

You can keep it open and let others weigh in on this
@shellhub
Copy link
Member Author

shellhub commented Aug 8, 2020

@shellhub shellhub reopened this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnanildutta swapnanildutta

@kvedala kvedala

Assignees
No one assigned
Labels
Admin views requested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@shellhub @kvedala @swapnanildutta
You can’t perform that action at this time.