The Wayback Machine - https://web.archive.org/web/20200916130852/https://github.com/TheAlgorithms/C/pull/595
Skip to content

/ C

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added segment_trees Closes #561 #595

Merged
merged 6 commits into from Sep 9, 2020
Merged

Feature: Added segment_trees Closes #561 #595

merged 6 commits into from Sep 9, 2020

Conversation

@Lakhan-Nad
Copy link
Contributor

Lakhan-Nad commented Aug 18, 2020 •
edited by gitpod-io bot

Description of Change

Added segment_trees code with a test on RMQ

References

Issue: #561

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Any change or update is welcome. If my code seems less documented please let me know where should I change.
@Lakhan-Nad
Feature: Added segment_trees Closes #561
Loading status checks…
9015e44
@kvedala kvedala linked an issue that may be closed by this pull request Aug 18, 2020
[FEATURE] Segment tree #561
Closed
@Lakhan-Nad
Copy link
Contributor Author

Lakhan-Nad commented Aug 20, 2020

@kvedala Sir, is there any suggestion or change request?
@kvedala
kvedala requested changes Aug 23, 2020
View changes
Copy link
Collaborator

kvedala left a comment

Thank you :)
Please update the code with specs provided in description and references from other files. The code is not formatted per the repo standards. You can simply enable GitHub Actions on your fork to enable auto-formatting of the code. No need to create any CI file, all the requirements are already present.
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
Lakhan-Nad and others added 2 commits Aug 23, 2020
@Lakhan-Nad
doc: documentation improved and explanations added
Loading status checks…
64920b2
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
5893311
@kvedala
Copy link
Collaborator

kvedala commented Aug 25, 2020

Please remove @fn tags from the code - refer to the warning
@kvedala
kvedala reviewed Aug 25, 2020
View changes
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
@Lakhan-Nad
doc: changes in documentation
Loading status checks…
c44eb82
@kvedala
kvedala requested changes Aug 25, 2020
View changes
Copy link
Collaborator

kvedala left a comment

👍 well done. minor fixes with docs
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
data_structures/binary_trees/segment_tree.c Show resolved Hide resolved
@Lakhan-Nad
doc: suggested doc changes and int types changed
Loading status checks…
279d2bc
@kvedala
kvedala approved these changes Aug 26, 2020
View changes
Copy link
Collaborator

kvedala left a comment

👍 LGTM
@Lakhan-Nad
Copy link
Contributor Author

Lakhan-Nad commented Aug 26, 2020

+1 LGTM

What with LGTM??
@kvedala
Copy link
Collaborator

kvedala commented Aug 26, 2020

+1 LGTM

What with LGTM??

meaning
@Lakhan-Nad
Copy link
Contributor Author

Lakhan-Nad commented Aug 26, 2020

+1 LGTM

What with LGTM??

meaning

OK :)
@Panquesito7
Panquesito7 approved these changes Sep 8, 2020
View changes
Copy link
Member

Panquesito7 left a comment

LGTM. 👍 😄
data_structures/binary_trees/segment_tree.c Outdated Show resolved Hide resolved
@Lakhan-Nad @Panquesito7
update: doc change for main function
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3da4ff2 
Co-authored-by: David Leal <[email protected]>
@Lakhan-Nad
Copy link
Contributor Author

Lakhan-Nad commented Sep 9, 2020

LGTM. +1 smile

Thanks
@kvedala kvedala merged commit e75d0e7 into TheAlgorithms:master Sep 9, 2020
5 checks passed
5 checks passed
Code Formatter
Details
Compile checks (ubuntu-latest)
Details
Compile checks (windows-latest)
Details
Compile checks (macOS-latest)
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvedala kvedala

@Panquesito7 Panquesito7

Assignees
No one assigned
Labels
approved enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[FEATURE] Segment tree
3 participants
@Lakhan-Nad @kvedala @Panquesito7
You can’t perform that action at this time.