Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(datetime): do not reset to am when changing hour and pm is set #21997
Conversation
|
Eric found an issue with this when adding in month + days, investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Dev build:
5.4.0-dev.202009102321.26d3971Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Open a datetime with an hour, minute and ampm column. Change to "pm" then change the hour. See the pm switch to am.
Issue Number: fixes #19175 fixes #19260 fixes #20026 references #16630
What is the new behavior?
Correctly remains on pm by setting it on the datetime value.
Does this introduce a breaking change?
Other information