The Wayback Machine - https://web.archive.org/web/20200901061226/https://github.com/TheAlgorithms/Python/pull/2229
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctests #2229

Merged
merged 1 commit into from Aug 1, 2020
Merged

Fix doctests #2229

merged 1 commit into from Aug 1, 2020

Conversation

@prashant616
Copy link
Contributor

prashant616 commented Jul 23, 2020 •
edited by itsvinayak

Describe your change:

Fix method name in recursive binary search doctests.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@prashant616
fix doctests for recursive binary search
Loading status checks…
1e1ef76
@ruppysuppy
ruppysuppy suggested changes Jul 24, 2020
View changes
Copy link
Contributor

ruppysuppy left a comment

Well done for identifying the improper doctests! Please add the type hints to the functions as well
@itsvinayak
itsvinayak approved these changes Aug 1, 2020
View changes
@itsvinayak
Copy link
Member

itsvinayak commented Aug 1, 2020

@prashant616 are you working on adding type hints as mentioned by @ruppysuppy
@cclauss
cclauss approved these changes Aug 1, 2020
View changes
@cclauss cclauss merged commit b57b6ab into TheAlgorithms:master Aug 1, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy

@cclauss cclauss

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@prashant616 @itsvinayak @cclauss @ruppysuppy
You can’t perform that action at this time.