Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update the authors script to generate the content of authors.md #36867
Conversation
scripts/authors.ts
Outdated
| @@ -162,6 +165,16 @@ namespace Commands { | |||
| console.log("====================="); | |||
| deduplicate(unknownAuthors).sort(sortAuthors).forEach(log); | |||
| } | |||
|
|
|||
|
|
|||
| const allAuthors = deduplicate([...knownAuthors, ...unknownAuthors].map(a => a.split("<")[0])).sort(sortAuthors); | |||
DanielRosenwasser
Feb 19, 2020
Member
If you split by < and pipe to a file, does that mean you'll end up with trailing whitespace on certain lines?
If you split by < and pipe to a file, does that mean you'll end up with trailing whitespace on certain lines?
orta
Feb 19, 2020
Author
Member
I'll trim to make sure anyway, though this isn't pipeable because it's part of a longer list command
I'll trim to make sure anyway, though this isn't pipeable because it's part of a longer list command
|
This actually greened on Travis, so I'm merging |
orta
merged commit e804dc8
into
microsoft:master
7 of 8 checks passed
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This file is now entirely auto-generated. I made a quick script with all the old names in to verify they are all in there from the file before I automated it afterwards.
Personally, I'm open to killing the mailmap file and making this script generate this file entirely - but for now this is good enough, we'll see where that conversation goes in teams.