The Wayback Machine - https://web.archive.org/web/20210828020847/https://github.com/scikit-learn/scikit-learn/pull/18256

scikit-learn / scikit-learn

Sponsor

Sponsor scikit-learn/scikit-learn
Notifications
Star 46.9k
Fork 21.8k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Enforce strict column name order/count in ColumnTransformer #18256

Merged

thomasjpfan merged 7 commits into scikit-learn:master from madhuracj:column_transformer

Nov 26, 2020

Contributor

madhuracj commented Aug 25, 2020 •

edited

Reference Issues/PRs

See #14223, #14237, #14251 and #14544

What does this implement/fix? Explain your changes.

This PR enforces strict column name order and count in ColumnTransformer and cleans up the intermediary codes that were used while the previous behaviour was being deprecated.
Basically, these changes are TODOs marked for v0.24.

Any other comments?

madhuracj added 2 commits


          Enforce strict column name order and count in ColumnTransformer

78c2b41


          Use self._check_n_features() and remove redundant checks

87809aa

github-actions bot added the module:compose label


          Fix linting

00be23e

Contributor Author

madhuracj commented Sep 10, 2020

Gentle reminder.

cmarmo added this to the 0.24 milestone

cmarmo added Waiting for Reviewer Blocker labels

Member

cmarmo commented Nov 24, 2020

@glemaitre @ogrisel, I've labeled as blocker because this pull request finalize some deprecations and remove TODOs for 0.24. Do you mind having a look? Thanks @madhuracj for your work and your patience.

thomasjpfan reviewed

Member

thomasjpfan left a comment

Thank you for the PR @madhuracj !

sklearn/compose/_column_transformer.py Outdated Show resolved Hide resolved

sklearn/compose/tests/test_column_transformer.py Outdated Show resolved Hide resolved

cmarmo removed the Waiting for Reviewer label

glemaitre self-requested a review


          apply review

24f2680

glemaitre reviewed

sklearn/compose/_column_transformer.py Outdated Show resolved Hide resolved

Contributor

glemaitre commented Nov 26, 2020

I made a small pushed to make the changes and I will add an entry in what's new

glemaitre added 3 commits


          add whats new

389efbc


          Merge remote-tracking branch 'origin/master' into pr/madhuracj/18256

07b35a2


          fix comment

e8ed802

glemaitre approved these changes

Contributor

glemaitre left a comment

LGTM

jeremiedbb approved these changes

Member

jeremiedbb left a comment

lgtm as well, thanks @madhuracj and @glemaitre

thomasjpfan approved these changes

Member

thomasjpfan left a comment

LGTM

thomasjpfan changed the title ~~Enforce strict column name order and count in ColumnTransformer~~ FIX Enforce strict column name order/count in ColumnTransformer

thomasjpfan merged commit 313568b into scikit-learn:master

26 checks passed

26 checks passed

triage

Details

Check build trigger

Details

Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}

Details

Source distribution

Details

Upload to Anaconda

Details

LGTM analysis: C/C++ No code changes detected

Details

LGTM analysis: JavaScript No code changes detected

Details

LGTM analysis: Python No new or fixed alerts

Details

ci/circleci: deploy Your tests passed on CircleCI!

Details

ci/circleci: doc Your tests passed on CircleCI!

Details

ci/circleci: doc artifact Link to 0/doc/_changed.html

Details

ci/circleci: doc-min-dependencies Your tests passed on CircleCI!

Details

ci/circleci: lint Your tests passed on CircleCI!

Details

codecov/patch 100.00% of diff hit (target 98.18%)

Details

codecov/project 98.18% (-0.01%) compared to 1e53ae2

Details

scikit-learn.scikit-learn Build #20201126.33 succeeded

Details

scikit-learn.scikit-learn (Linting) Linting succeeded

Details

scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded

Details

scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded

Details

scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded

Details

scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded

Details

scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded

Details

scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded

Details

scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded

Details

scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl) macOS pylatest_conda_forge_mkl succeeded

Details

scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded

Details

rth mentioned this pull request

RFC ColumnTransformer input validation and requirements #14251

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment