Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCancelled lock waiter wakes up the next one if any #467
Conversation
|
@gvanrossum @asvetlov I'm not sure I can review this (I never touched/used that code). Can you take a look if you have time and you are familiar with the code? |
|
Sorry, I can't do it this week or next.
|
| @@ -71,6 +71,31 @@ def test_context_manager_with_await(self): | |||
| self.loop.run_until_complete(test(primitive)) | |||
| self.assertFalse(primitive.locked()) | |||
|
|
|||
| def test_finished_waiter_cancelled(self): | |||
|
|
|||
| async def create_waiter(lock, fut): | |||
This comment has been minimized.
This comment has been minimized.
1st1
Nov 17, 2016
Member
Please use the @coroutine decorator and generators in unittests. We'll start using 'async def' when 3.6 is out and we start working on Python 3.7.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1st1
Nov 17, 2016
Member
test_pep492 is ignored on Pythons < 3.5 and it tests specifically async/await and asyncio.
Yeah, this test should be where all tests of lock/synchronization primitives are.
|
Looks like this PR is doing a right thing. @msornay please update the tests, and I will merge it. |
Python issue #27585
the-knights-who-say-ni
commented
Nov 17, 2016
|
Hello, and thanks for your contribution! Unfortunately we couldn't find an account corresponding to your GitHub username at bugs.python.org (b.p.o). If you don't already have an account at b.p.o, please create one and make sure to add your GitHub username. If you do already have an account at b.p.o then please go there and under "Your Details" add your GitHub username. And in case you haven't already, please make sure to sign the PSF contributor agreement (CLA); we can't legally look at your contribution until you have signed the CLA. Once you have done everything that's needed, please reply here and someone will verify everything is in order. |
|
Everything should be in order. |
pklanke
commented
Jan 9, 2017
|
After applying patch #363 and #467 to Python 3.5.2, the dead-lock did indeed no longer occur, but the opposite did; Sometimes on releasing the lock, a RuntimeError exception is raised telling me the lock was not acquired. lock.acquire() So far, I did not manage to create a simple test case, and I know this does not help much without it, but should someone experience this same behavior, then just know you are not the only one. |
|
Please reopen this PR at https://github.com/python/cpython. This repo is going to be deleted soon. |
msornay commentedNov 16, 2016
Fixes http://bugs.python.org/issue27585
Without the fix the unit test deadlock, I haven't managed to make it fail (using wait_for() seems to avoid the deadlock)