The Wayback Machine - https://web.archive.org/web/20200907135033/https://github.com/javalite/javalite/pull/775
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#238 Provide ability to update only single field (or particular set of fields) during model save #775

Open
wants to merge 9 commits into
base: master
from

Conversation

@devMls
Copy link

devMls commented Aug 28, 2018

Allow specify columns to update

Allow specify columns to update in the methods save and saveit

If the specification is done, the validations will not be trigged

devMls added 4 commits Aug 28, 2018
don't do validations if fields are specified
or exception
@ipolevoy
Copy link
Member

ipolevoy commented Aug 28, 2018

@devMls what is this about? Can you please create an issue and explain this, see: http://javalite.io/contributors

Also, please use the same format for commits "#123 Issue title - additional comments".

@devMls devMls changed the title Allow specify columns to update #238 Provide ability to update only single field (or particular set of fields) during model save Aug 29, 2018
@ipolevoy
Copy link
Member

ipolevoy commented Sep 12, 2018

@devMls can you please see my comments above? Just sending commits is not helpful. Also, your code has no associated tests.

@devMls
Copy link
Author

devMls commented Sep 12, 2018

Hi.

I try to resolve this issue:

#238

Where vyemialyanchyk asking for a way to update only some fields, for avoid to get all record from database, or manage a clob field for update only a boolean.

With this functionality you can:

model.save("field1, field2");
I find this helpful, this week i will implement tests.

devMls added 4 commits Sep 12, 2018
@ipolevoy
Copy link
Member

ipolevoy commented Sep 13, 2018

@devMls all commits must follow a pattern as I described above. Can you please:

  1. Close this PR
  2. Create a new PR and commit messages that follow the rules
  3. Add tests around new functionality
@ipolevoy ipolevoy force-pushed the javalite:master branch from f8258bc to 05d9da3 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.