Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
WIP - Use opaque sequence token in message cache #5948
Conversation
…age cache. Intened to address #5879
jason-bragg
force-pushed the
jason-bragg:streams/OpaqueSequenceNumber
branch
from
5f3e4c9
to
34611a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We now use opaque streamId, sequence token, and offsets in stream message cache.
This is intended to address #5879
Will also help us move to more robust streamId.
PooledQueueCache is mostly ok, but cruft translating opaque cached data to pre-existing types is a bit ick.
Also, eviction strategy still has logic that shouldn't be there.
Getting this out for review, but want to let the patterns bake for a bit before committing to this path.
@Frank-Krick