Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded partial support for generating sketch prototypes #84
Conversation
This is part of the sketch conversion process.
This is because the function returns the path to the header file and not just whether is exists or not. This change also caused separation of the function into a dedicated file
It detects which prototypes need to be generated, based on the def-dec matching ability previously added
Added utility function to escape semicolons in a string and vice-versa Fixed bug in `list_max_index` utility function
It now fully supports both platform header & prototypes insertion
Fixed small function argument-stripping bug
Uncommented examples other than 'sketch'
MrPointer
force-pushed the
feature/sketch-func-prototypes
branch
from
83255b2
to
6e060ab
On Linux CMake might find avr-gcc first inside ccache folder which leads to wrong ar/ranlib detection. On Fedora 30 at least, it leads to link errors because it uses avr-ar/ranlib instead of avr-gcc-ar/ranlib. Signed-off-by: Alexis Jeandet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MrPointer commentedApr 27, 2019
The support is partial due to the fact that complete prototype generation just can't be achieved with CMake - Further discussion can be found at the comments of #32.
Currently, this work redesigns how sketches are converted, but also adds basic prototype generation - Somewhat dumb, as it sometimes generates prototypes even when a matching declaration exists.
As described in #32, this whole conversion process should be done outside the framework, thus it should be developed as an external tool in a better-suited environment, such as Python.