Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/280/output dds #329
Open
Conversation
|
Initial review for C++ Classic |
perftest_qos_profiles.xml
Outdated
| <resource_limits> | ||
| <max_samples>10</max_samples> | ||
| <initial_samples>1</initial_samples> | ||
| <max_samples_per_instance>1</max_samples_per_instance> |
Comment on lines
1102
to
1105
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srcIdl/perftest.idl
Outdated
| @optional unsigned long long min; | ||
| @optional unsigned long long max; | ||
| @optional unsigned long long h50; | ||
| @optional unsigned long long h90; | ||
| @optional unsigned long long h99; | ||
| @optional unsigned long long h9999; | ||
| @optional unsigned long long h999999; |
Comment on lines
202
to
208
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srcIdl/perftest.idl
Outdated
| @optional unsigned long long packets; | ||
| @optional unsigned long long packetsS; |
Comment on lines
190
to
191
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
javmorcas
Jun 15, 2020
Member
Lets call them:
packets
packetsPerSecond
packetsAverage
mbps
mbpsAverage
lostPackets
lostPacketsPercent
This comment has been minimized.
This comment has been minimized.
pparrilla
Jun 15, 2020
Author
Collaborator
ok, but in perftest_publisher.cpp, packets and packetsPerSecond are unsigned long long data types
srcIdl/perftest.idl
Outdated
| @optional perftestLatencyInfo pLatencyInfo; | ||
| @optional perftestThroughputInfo pThroughputInfo; | ||
| @optional double outputCpu; | ||
| }; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srcIdl/perftest.idl
Outdated
| @optional double packetsAve; | ||
| @optional double mbps; | ||
| @optional double mbpsAve; | ||
| @optional unsigned long long lost; |
This comment has been minimized.
This comment has been minimized.
srcCpp/perftest_publisher.cxx
Outdated
| @@ -1334,6 +1318,7 @@ class LatencyListener : public IMessagingCB | |||
| IMessagingWriter *_writer; | |||
| ParameterManager *_PM; | |||
| PerftestPrinter *_printer; | |||
| LatencyInfo _latInfo; | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srcCpp/perftest_publisher.cxx
Outdated
| @@ -1391,6 +1376,9 @@ class LatencyListener : public IMessagingCB | |||
| _PM = &PM; | |||
| _printer = printer; | |||
|
|
|||
| _latInfo.dataLength = _printer->_dataLength; | |||
This comment has been minimized.
This comment has been minimized.
javmorcas
Jun 15, 2020
Member
I think you can use last_data_length instead of asking the _printer for the datalen.
This comment has been minimized.
This comment has been minimized.
javmorcas
Jun 15, 2020
Member
It feels weird asking an structure for a member that you are going to later set in the same structure
This comment has been minimized.
This comment has been minimized.
srcCpp/RTIDDSImpl.h
Outdated
| DDSDomainParticipant *participant; | ||
| DDSPublisher *publisher; | ||
| DDSTopic *topic; | ||
| perftestInfoDataWriter *ptInfoWriter; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srcCpp/RTIDDSImpl.h
Outdated
| DDSPublisher *publisher; | ||
| DDSTopic *topic; | ||
| perftestInfoDataWriter *ptInfoWriter; | ||
| perftestInfo *ptInfo; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| DDS_PublisherQos publisherQos; | ||
| DDS_DataWriterQos dwQos; | ||
|
|
||
| #ifndef RTI_MICRO |
This comment has been minimized.
This comment has been minimized.
javmorcas
Jun 15, 2020
Member
Can we check what is the behavior when using micro? We might need to make this differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pparrilla commentedJun 10, 2020
This pull request is coming from the issue #280