Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAutocompletion #22
Open
Autocompletion #22
Conversation
codecov-io
commented
Aug 8, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
============================================
+ Coverage 81.79% 82.82% +1.02%
- Complexity 137 143 +6
============================================
Files 11 12 +1
Lines 357 390 +33
Branches 72 73 +1
============================================
+ Hits 292 323 +31
- Misses 30 32 +2
Partials 35 35
Continue to review full report at Codecov.
|
|
Sorry it took so long for me to review this. I was swamped with other stuff. Overall, this looks great! Thank you for this contribution. I only have a few minor suggestions. |
| class ShowAutoCompletionException internal constructor( | ||
| private val autoCompletion: AutoCompletion, | ||
| private val delegates: List<ArgParser.Delegate<*>> | ||
| ) : SystemExitException("Help was requested", 0) { |
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,49 @@ | |||
| // Copyright © 2016 Laurence Gonsalves | |||
This comment has been minimized.
This comment has been minimized.
| class DefaultAutoCompletion : AutoCompletion { | ||
| override fun format(progName: String?, delegates: List<ArgParser.Delegate<*>>): String { | ||
| val sb = StringBuilder() | ||
| sb.append("_$progName()\n") |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NoFr1ends commentedAug 8, 2017
Fix #9
Implement basic functionallity for generating bash/zsh autocompletion script.
Note: The implementation of Delegate:toAutoCompletion is maybe not the best way to do this. But I needed a way to access the optionNames.