The Wayback Machine - https://web.archive.org/web/20201123153111/https://github.com/shelljs/shelljs/pull/662
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up RELEASE.md #662

Merged
merged 1 commit into from Feb 27, 2017
Merged

docs: clean up RELEASE.md #662

merged 1 commit into from Feb 27, 2017

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Feb 11, 2017

Miscellaneous changes.

npm run gendocs is actually done as part of the CI, so it isn't necessary to run it manually for a release.

@nfischer nfischer added the docs label Feb 11, 2017
@nfischer nfischer requested a review from freitagbr Feb 11, 2017
RELEASE.md Outdated
- `$ git push`
5. Generate the documentup website by visiting
[http://documentup.com/shelljs/shelljs/__recompile] in your browser
1. Generate the documentup website by visiting

This comment has been minimized.

@freitagbr

freitagbr Feb 17, 2017
Contributor

The numbers need to be incremented.

This comment has been minimized.

@nfischer

nfischer Feb 21, 2017
Author Member

Sure. For what it's worth, the number can actually be anything, it doesn't have to increment. Here are the official docs and here is a guide which demonstrates that.

I've seen the 1-only style preferred other places. I suppose this might likely be read in the terminal, so the real numbers might be more helpful.

This comment has been minimized.

@freitagbr

freitagbr Feb 21, 2017
Contributor

Wow, I had no idea that was a thing!

This comment has been minimized.

@nfischer

nfischer Feb 26, 2017
Author Member

Fixed.

Miscellaneous changes.
@nfischer nfischer force-pushed the docs-fix-release-steps branch from f4f181b to 7b52dd8 Feb 26, 2017
@nfischer
Copy link
Member Author

@nfischer nfischer commented Feb 26, 2017

@freitagbr PTAL

@freitagbr
Copy link
Contributor

@freitagbr freitagbr commented Feb 27, 2017

LGTM

@freitagbr freitagbr merged commit 006b8c2 into master Feb 27, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nfischer nfischer deleted the docs-fix-release-steps branch Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.