Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
5,206 contributions in the last year
Activity overview

Contribution activity
September 2020
Created a pull request in apple/swift-package-manager that received 21 comments
PackageLoading,Workspace: derive flags for Windows
Use the special environment variable named SDKROOT
which provides the
root of the SDK as a means for deriving the flags for building code on
Window…
+195
−12
•
21
comments
- Replace inline license text with SPDX identifier
- UI: fix a typo in a variable name in `Screen` (NFC)
- UI: avoid unnecessary zero'ing in `Device.current.name`
- UI: add `Responder` for setting up a responder chain
- UI: reorder the view hierarchy management declarations (NFCI)
- Support: remove redundant zero'ing
- Support: move `WindowClass` into `Support`
- UI: avoid spelling out the class names for `Switch` and `Label`
- UI: use the constant for the Button Window Class
- Support: add new `Error` type
- UI: namespace `window` further into a variable (NFCI)
- Application: flesh out `ApplicationDelegate`
- UI: explicit destroy the window when a `View` is deinited
- Examples: add an empty "Hello World" example
- UI: add typography information to font
- UI: populate more of `TraitCollection`
- UI: make `TraitCollection.current` a stored property
- build: split up `Application` and `UI` sources
- UI: add `isOn` and `setOn(_:animated:)` to `Switch`
- UI: extend `Font` properties
- UI: reflow some text to better adhere to 80-col (NFC)
- UI: remove minimize/maximize boxes from the titlebar
- UI: add support to determine the current orientation
- UI: add support for placeholder text in `TextField`
- Support: adjust `_Win32WindowText` property wrapper
- Some pull requests not shown.
- Update vs2019.yml
- CI: add IndexStoreDB to devtools
- WIX: autogenerate component guids at compile time
- WIX: exclude CF headers for newer toolchains
- WIX: duplicate CF headers for flag handling
- build: further tweak layout
- WIX: hoist import libraries a level
- Update swift-log.yml
- WIX: add files for new swiftmodule layout
- build: add a workaround symlink for 5.3 builds
- Installer updates
- CI: add a couple of plists
- WIX: include Yams in devtools MSI
- CI: remove devtools stage from 5.3 builds
- CI: package devtools in tensorflow builds
- CI: attempt to package devtools into a MSI
- CI: use python 3.7 explicitly
- CI: remove hardcoded python handling
- Update swift-installer-bundle.yml
- NIO: implement address resolution for Windows
- NIO: invalid sockets are not `-1` but `INVALID_SOCKET`
- NIO: improvements to Windows BSD API
- NIO: shave off parts of System
- NIO: make BSDSocketAPI build on Windows
- NIO: implement `cleanupSocket(unixDomainSocketPath:)` for Windows
- NIO: ignore `SIGPIPE` on Windows
- NIO: add import for the C library for Windows
- NIO: implement network interface enumeration for Windows
- CNIOWindows: correct declaration
- CNIOWindows: add stubs for `sendmmsg` and `recvmmsg`
- NIO: import additional values from WinSDK
- CNIOWindows: preprocess away WinSock support code
- build: add `CNIOWindows` to Package.swift
- NIO: repair the build after e3508b0d0
- NIO: remove `poll` from the `_BSDSocketProtocol` protocol
- NIO: remove unnecessary `@discardableResult`
- NIO: fix `close(socket:)`
- build: bump tools version to 5.3
- Platform: correct linked import library name
- build: repair cross-compilation for Windows after #33908
- Revert "build: allow falling back to just built compiler"
- build: allow falling back to just built compiler
- build: use the just build compiler if available
- build: begin wiring up swift-argument-parser
- Update WindowsBuild.md
- caches: add a cache for building just the runtime on Windows
- Update WindowsBuild.md
- utils: quote argument to `subprocess.Popen`
- AST: align `ImportedModule` to 64-bits
- Platform: improve WinSDK modulemap to repair build
- Revert "[IRGen] Use the lexical decl context for VarDecls."
- SILOptimizer: correct accidental `>=` to `>`
- build: merge changes for rebranching
- utils: add a timeout to the integration tests
- SILOptimizer: make vtable pruning less aggressive
- build: repair the build for newer MSVC release
- Sema: add support for `__attribute__((__swift_private__))`
- Sema: clean up unused code paths after upstreaming
- Sema: add support for `__attribute__((__swift_newtype__))`
- [5.3] REPL fixes for Windows
- Sema: introduce `__attribute__((__swift_name__))`
- Sema: introduce `__attribute__((__swift_name__))`
- Sema: add support for `__attribute__((__swift_bridge__))`
- Sema: add support for `__attribute__((__swift_bridged_typedef__))`
- ExpressionParser: adjust triple handling for Swift REPL on Linux
- TypeSystem: normalize the Windows triple
- Sema: add support for `__attribute__((__swift_objc_members__))`
- Sema: add support for `__attribute__((__swift_error__))`
- TypeSystem: repair the build on Windows
- Create ${swig_target}-scripts target instead of lldb-python-scripts
- Update CMakeLists.txt
- Fix swig scripts install target name
- Workspace: remove unnecessary flags on Windows
- Build: correct lookup for `libIndexStore.dll` on Windows
- Workspace: handle `/MT`, `/MTd`, `/MD`, `/MDd` for C/C++
- Commands: make `swift test` work on Windows
- build: list the `PackageLoading` dependency
- Build: repair the build after apple/swift-driver#144
- build: loosen swfit-argument-parser dependency
- WinSDK: extract version into a separate submodule
- WinSDK: extract Performance submodule
- Make MinSizeRel builds produce debug info
- WinSDK: extract Printing submodule
- WinSDK: extract Multimedia submodule
- Avoid using extra-cmake-options in the stdlib standalone presets
- WinSDK: add console API headers
- [windows] Use update-checkout in build-windows.bat
- [docs] Note that cross repo testing doesn't work for Windows CI.
- Specify Float80 as supported on OpenBSD.
- Add a different implementation of Differentiation
- WinSDK: extract Controls submodule
- [build-script-impl] Add a comment explaining why an option isn't truly dead as per reviewers suggestion.
- [test] diff --strip-trailing-cr is non-standard.
- WinSDK: extract Internationalization submodule
- [Localization] Tests: Track and remove temporary files on fixture tea…
- Use uppercase CMAKE_BUILD_TYPE when asking for CMAKE_CXX_FLAGS, explicitly use -O0 for Debug builds
- [docs] Fix WindowsBuild.md
- WinSDK: add Shell32
- Don't use resilient getter for playgroundPrintHook when resilience is off
- [docs] Deprecate Python 2 in build instructions
- Add a SWIFT_STDLIB_OS_VERSIONING flag to avoid querying OS version at runtime, use it in the freestanding build
- [test][IRGen] Maybe Windows needs dso_local.
- [test][IRGen] Fix check on local_extern test.
- Delete build-windows-rebranch.bat
- Some pull request reviews not shown.
4
contributions
in private repositories
Sep 10