The Wayback Machine - https://web.archive.org/web/20201009044915/https://github.com/angular/angular/issues/39156
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show All not working on api/common/http/HttpRequest #39156

Closed
frederikprijck opened this issue Oct 7, 2020 · 2 comments
Closed

Show All not working on api/common/http/HttpRequest #39156

frederikprijck opened this issue Oct 7, 2020 · 2 comments
Labels
P4 comp: docs-infra good first issue
Milestone
Backlog

Comments

@frederikprijck
Copy link
Contributor

@frederikprijck frederikprijck commented Oct 7, 2020 •
edited

📚 Docs or angular.io bug report

Description

On the https://angular.io/api/common/http/HttpRequest link, clicking the Show All underneath the constructor doesnt expand the section. Clicking anywhere else (e.g. on 3 overloads) works fine.

🔬 Minimal Reproduction

What's the affected URL?

https://angular.io/api/common/http/HttpRequest

Reproduction Steps

  • Scroll to the constructor section
  • Click Show All or the Carret behind it

Expected vs Actual Behavior

It should expand while currently it does not.

📷Screenshot

image

🔥 Exception or Error

N/A

🌍 Your Environment

Browser info

Chrome Version 85.0.4183.121 (Official Build) (64-bit)
@ngbot ngbot bot modified the milestone: Backlog Oct 7, 2020
@petebacondarwin

Loading…

Member

@petebacondarwin petebacondarwin commented Oct 7, 2020

The Show All is wrapped in an <a> tag, which is blocking the click from reaching the enclosing <summary> tag.
Removing the <a> wrapper fixes the behaviour but messes up the styling. So I think just a bit of tweaking in

angular/aio/tools/transforms/templates/api/lib/memberHelpers.html

Lines 135 to 139 in 0681a20

<a>
<span class="show-all">Show All</span>
<span class="collapse-all">Hide All</span>
<i class="material-icons expand">expand_more</i>
</a>

and

angular/aio/src/styles/2-modules/_api-pages.scss

Lines 33 to 48 in d8f9ec5

summary {
height: inherit;
padding: 0;
h4 {
margin: 0;
clear: left;
}
.show-all {
display: initial;
}
.collapse-all {
display: none;
}
}

is needed.
@marcinmilewicz

Loading…

@marcinmilewicz marcinmilewicz commented Oct 7, 2020

I'd take it
@ChellappanRajan ChellappanRajan mentioned this issue Oct 8, 2020
Closed
2 of 12 tasks complete
ChellappanRajan added a commit to ChellappanRajan/angular that referenced this issue Oct 8, 2020
@ChellappanRajan
docs: fix for HttpRequest expansion panel
15baaf8 
Fixes #angular#39156
ChellappanRajan added a commit to ChellappanRajan/angular that referenced this issue Oct 8, 2020
@ChellappanRajan
docs: fix for HttpRequest expansion panel
0eb8b48 
Fixes angular#39156
@atscott atscott closed this in dace4aa Oct 8, 2020
atscott added a commit that referenced this issue Oct 8, 2020
@ChellappanRajan @atscott
docs: fix for HttpRequest expansion panel (#39166)
Loading status checks…
b417dd7 
Fixes #39156

PR Close #39166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 comp: docs-infra good first issue
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@petebacondarwin @frederikprijck @marcinmilewicz
You can’t perform that action at this time.