Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upread double value by BigDecimal #235
Open
Conversation
t-mangoe
changed the title
codecov-io
commented
Apr 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 68.46% 68.47% +<.01%
==========================================
Files 107 107
Lines 7335 7340 +5
Branches 1388 1388
==========================================
+ Hits 5022 5026 +4
- Misses 1867 1868 +1
Partials 446 446
Continue to review full report at Codecov.
|
|
@t-mangoe where are tests that reproduces a problem with doubles? and, why you have mixed it with the fix for surrogate pairs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
t-mangoe commentedApr 13, 2019
•
edited
I fixed code. I think this fix solves the issue #206 . If you like, please merge.