The Wayback Machine - https://web.archive.org/web/20201012103300/https://github.com/getopt-php/getopt-php/pull/164
Skip to content

/ getopt-php

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stuffs about assertion call and assertions #164

Open
wants to merge 1 commit into
base: master
from
Open

Improve stuffs about assertion call and assertions #164

wants to merge 1 commit into from

Conversation

@peter279k
Copy link

@peter279k peter279k commented Aug 14, 2020

Changed log

  • Using the assertNull to assert expected is null.
  • PHPUnit has two ways to make assertion call. One is $this and another one is self::.
    It seems that using self:: times is greater than using $this.
    To be consistency, using the self to make assertion call on this repository.
  • Using the assertSame to replace assertEquals and it can let all assertions make equals checking strictly.
@peter279k
Improve stuffs about assertion call and assertions
Loading status checks…
1f36116
@coveralls
Copy link

@coveralls coveralls commented Aug 14, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 1f36116 on peter279k:test_enhancement into 63a3731 on getopt-php:master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@peter279k @coveralls
You can’t perform that action at this time.