The Wayback Machine - https://web.archive.org/web/20201101090550/https://github.com/mysqljs/mysql/pull/1749
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stale connections that have not been used for idletimeout. #1749

Open
wants to merge 6 commits into
base: master
from

Conversation

@aankur
Copy link

@aankur aankur commented Jun 6, 2017

#962 Add ability to remove connections from the pool which have been stale for idletimeout period in milliseconds

aankur added 3 commits Jun 6, 2017
@4ver
Copy link

@4ver 4ver commented Jun 20, 2017

Might be a good idea to change the following shift to pop to prevent the pool from cycling through the connections keeping em all alive.

https://github.com/mysqljs/mysql/blob/master/lib/Pool.js#L37

@dougwilson dougwilson force-pushed the mysqljs:master branch 2 times, most recently from 638d79d to 88bade0 Jun 29, 2017
@adriancooney
Copy link

@adriancooney adriancooney commented Aug 29, 2017

Any more movement on this? Our instances are hogging connections for too long and it'd be great to be able to close out those idle connections.

aankur added 3 commits Aug 30, 2017
@akleiber
Copy link

@akleiber akleiber commented Mar 19, 2020

duplicate of #2218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.