The Wayback Machine - https://web.archive.org/web/20201101090234/https://github.com/mysqljs/mysql/pull/2385
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashing fix due to protocol error #2385

Open
wants to merge 1 commit into
base: master
from

Conversation

@imanshugupta
Copy link

@imanshugupta imanshugupta commented Aug 10, 2020

protocol error emits error event which is not properly handleled which causes node app crash.
Its a preventation of app crash

protocol error emits error event which is not properly handleled which causes node app crash.
Its a preventation of app crash
Copy link
Member

@dougwilson dougwilson left a comment

Thank you for your pull request! Please be sure to update this by following the steps outlined in https://github.com/mysqljs/mysql#contributing like the following:

  1. Try to include a clear description of your pull request in the description. It should include the basic "what" and "why"s for the request.
  2. The pull request should include tests for the change. A new feature should have tests for the new feature and bug fixes should include a test that fails without the corresponding code change and passes after they are applied. The command npm run test-cov will generate a coverage/ folder that contains HTML pages of the code coverage, to better understand if everything you're adding is being tested.
  3. If the pull request is a new feature, please be sure to include all appropriate documentation additions in the Readme.md file as well.
  4. To help ensure that your code is similar in style to the existing code, run the command npm run lint and fix any displayed issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.