The Wayback Machine - https://web.archive.org/web/20201013072859/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1240
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive implementation of Bubble sort #1240

Open
wants to merge 4 commits into
base: master
from

Conversation

@Krishnapal4050
Copy link

@Krishnapal4050 Krishnapal4050 commented Oct 10, 2020

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

github-actions and others added 3 commits Oct 10, 2020
github-actions github-actions
@Krishnapal4050
Copy link
Author

@Krishnapal4050 Krishnapal4050 commented Oct 10, 2020

@kvedala As suggested by you, when I rebased that branch, that pull request got closed automatically. So, I had to create a new PR after rebasing this branch.
Please review it now and give your valuable suggestions.

@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

👍
Please review the contribution guidelines. Especially: https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#typical-structure-of-a-program
and update the code before the review. Thank you

@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 11, 2020

You can also review the existing code: https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/sorting/insertion_sort.cpp for reference.

sorting/recursive_bubble_sort.cpp Outdated Show resolved Hide resolved
sorting/recursive_bubble_sort.cpp Show resolved Hide resolved
#include<iostream>
#include <array>

void recBubble(std::array<int,10> arr, int n){

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 12, 2020
Member

Missing function documentation.

@@ -113,7 +113,9 @@
* [Adaline Learning](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/adaline_learning.cpp)
* [Kohonen Som Topology](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_topology.cpp)
* [Kohonen Som Trace](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/kohonen_som_trace.cpp)
* [Neural Network](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/machine_learning/neural_network.cpp)

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 12, 2020
Member

I don't know why is this being added, but I think it should be removed.

Co-authored-by: David Leal <[email protected]>
@github-actions github-actions bot force-pushed the Krishnapal4050:bubble-sort branch from f4a7df9 to 6a9cdf9 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.