The Wayback Machine - https://web.archive.org/web/20201010215630/https://github.com/scikit-image/scikit-image/pull/5012
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example for structure_tensor... in 3D! #5012

Open
wants to merge 4 commits into
base: master
from

Conversation

@mkcor
Copy link
Contributor

@mkcor mkcor commented Oct 9, 2020

Description

Addresses part of #4831.
With this PR, I'm following up on #4831 (comment).

@emmanuelle I tried telling a story but, in terms of applications, it's more didactic than scientific.
@GenevieveBuckley I used a small region of the kidney image!

I wanted to include some 3D rendering with Plotly, like:
3d_isotropy
but it would only spit out a JSON:

{'text/html': '<div>            <script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.5/MathJax.js?config=TeX-AMS-MML_SVG"></script><script type="text/javascript">if (window.MathJax) {MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}</script>                <script type="text/javascript">window.PlotlyConfig = {MathJaxConfig: \'local\'};</script>\n        <script src="https://cdn.plot.ly/plotly-latest.min.js"></script>                <div id="de5ac8b7-d7bc-41f1-a094-bc28e8cdaa06" class="plotly-graph-div" style="height:525px; width:100%;"></div>            <script type="text/javascript">                                    window.PLOTLYENV=window.PLOTLYENV || {};                                    if (document.getElementById("de5ac8b7-d7bc-41f1-a094-bc28e8cdaa06")) {                    Plotly.newPlot(                        "de5ac8b7-d7bc-41f1-a094-bc28e8cdaa06",                        [{"opacity": 0.5, "slices": {"z": {"locations": [5], "show": true}}, "type": "volume", "value": [774, 566, 384, 333, ...

(plus it would be too heavy).

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
@pep8speaks
Copy link

@pep8speaks pep8speaks commented Oct 9, 2020

Hello @mkcor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 196:1: E402 module level import not at top of file

Comment last updated at 2020-10-09 21:13:00 UTC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.