Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDOC Stop referencing preprocessing functions in user guide #18281
Comments
These are the references of the preprocessing functions in the user guide:
Maybe it is better to have all this information in the issue description @lucyleeow? |
I think this is a good step. I'm not sure it needs a checklist, as I think it can be done in one pr, but code to check whether the job is done might be helpful. |
You are absolutely right. Indeed, I would also recommend to solve this issue in one PR. I have updated the comment to remove the checklist, but I have kept the information for contributors. |
Hi, does anyone work on it? I can give it a try otherwise |
If you comment 'take' the bot should assign it to you. |
Take |
Hey @OlehKSS! I think that it should be "take" instead of "Take". Note: I think that it would be interesting to consider both options in the CC @thomasjpfan |
I think it the comment has to be just 'take' (without any other words) as well: https://scikit-learn.org/dev/developers/contributing.html#contributing-code |
take |
Hi @OlehKSS did you finish working in this issue? Do you need help? |
Describe the issue linked to the documentation
Follows from #17387
Suggest a potential alternative/fix
Stop referencing preprocessing functions e.g. :
maxabs_scale
minmax_scale
normalize
quantile_transform
robust_scale
scale
power_transform
in the UG, and only add them e.g. in the "See Also" sections, or even just in the API ref.
In particular right now the first entry of the Preprocessing guide is scale. I think it should be StandardScaler within a pipeline.