The Wayback Machine - https://web.archive.org/web/20201003114718/https://github.com/jagrosh/GiveawayBot/issues/28
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giveaways ending in future day(s) show ending "today" #28

Open
CynnaMonkey opened this issue Apr 30, 2019 · 4 comments
Open

Giveaways ending in future day(s) show ending "today" #28

CynnaMonkey opened this issue Apr 30, 2019 · 4 comments
Labels

Comments

@CynnaMonkey
Copy link

@CynnaMonkey CynnaMonkey commented Apr 30, 2019

I posted a giveaway scheduled to end in 2 days. In the post it says "ends at: Today" with the time it posted which was the past. It does correctly say "Time remaining: 2 days".Image

@jagrosh
Copy link
Owner

@jagrosh jagrosh commented Apr 30, 2019

Do you encounter the same issue across multiple clients (desktop, browser, and mobile)?
What do other members of the server see?

@Purpzie
Copy link

@Purpzie Purpzie commented May 9, 2019

That one seems like a Discord embed issue, not with GiveawayBot. Basically, the embed only gets a timestamp (to allow it to be displayed in any timezone), and it's up to Discord to decide how it gets displayed. GiveawayBot doesn't control that part of the embed.

There is already a report on this which you can find here and you can also add your own canrepro to it here with !canrepro 1626 | <your device information> in the #android-bug-reports channel.

@Sanduhr32
Copy link
Collaborator

@Sanduhr32 Sanduhr32 commented May 9, 2019

We can controll the universal time but we can not change the client rendering and since desktop and android are hit by this issue I assume it's a general converting issue in any discord client.

I personally also encountered this issue and tried to resolve it but quickly noticed it client sided and looked the code up.
The code never modifies the ending time, it just sets it on the creation of a giveaway.

For Developers

Yes we do resend the embed timestamp each time we update the embed for avoiding its removal.

@jagrosh jagrosh added the discord bug label May 22, 2019
@jagrosh
Copy link
Owner

@jagrosh jagrosh commented May 22, 2019

Yeah, this is a bug with Discord's rendering of the timestamp, and is out of our power to fix because it only happens on some clients (we can't use an intentionally-wrong timestamp to get around this, because then the timestamp would be wrong for other people)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.