The Wayback Machine - https://web.archive.org/web/20201106140813/https://github.com/netlify/js-client/issues/149
Skip to content

/ js-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support specifying commit sha/URL when creating/updating a deploy #149

Open
erezrokah opened this issue Sep 10, 2020 · 1 comment
Open

Feature: Support specifying commit sha/URL when creating/updating a deploy #149

erezrokah opened this issue Sep 10, 2020 · 1 comment
Labels
area: api type: feature

Comments

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Sep 10, 2020

Related to netlify/cli#1122

- Do you want to request a feature or report a bug?

Feature

- What is the current behaviour?

Manual deploys shown in the Netlify UI are not linked to any commit.

- What is the expected behaviour?

An option should be provider to tag a deploy with a commit sha or URL so one could click the deploy in the Netlify UI and be redirected to the relevant commit in the repo.

- Possible workaround

Use the message argument, but that doesn't create a link in the UI
@erezrokah erezrokah mentioned this issue Sep 10, 2020
Open
@ingride
Copy link
Contributor

@ingride ingride commented Sep 10, 2020 •
edited

The deploy object has the following attributes we would need to expose and receive

Commit details:

    attributes[:commit_ref] # this is the actual sha
    attributes[:committer_slug] # the commiter slug
    attributes[:committer_name] # the commiter name if set

PR details:

   attributes[:review_id] # PR number - example: 123
   attributes[:review_url] # PR URL - example https://github.com/netlify/js-client/pull/123"

I think this becomes a matter of making those available in the Open-API and passing them in when creating a deploy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api type: feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ingride @erezrokah
You can’t perform that action at this time.