The Wayback Machine - https://web.archive.org/web/20220519204023/https://github.com/plotly/plotly.js/pull/4930
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop cwise and inline ndarray-homography #4930

Merged
merged 2 commits into from Jun 19, 2020
Merged

drop cwise and inline ndarray-homography #4930

merged 2 commits into from Jun 19, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 18, 2020

The follow up of #4929,

zero

no longer depend on cwise resolves #4796
also to simplify the build process
and optimized for 2d operations as well as inverting the input matrix once.

@plotly/plotly_js

alexcjohnson
alexcjohnson reviewed Jun 18, 2020
View changes
src/traces/surface/convert.js Outdated Show resolved Hide resolved
@alexcjohnson
Copy link
Contributor

@alexcjohnson alexcjohnson commented Jun 18, 2020

Fantastic work! Can we add a test to 🔒 the "found 0 vulnerabilities" audit result?

@archmoj
Copy link
Contributor Author

@archmoj archmoj commented Jun 18, 2020

Fantastic work! Can we add a test to the "found 0 vulnerabilities" audit result?

Hmm.. not in this PR. But let's think about it.

@nicolaskruchten
Copy link
Member

@nicolaskruchten nicolaskruchten commented Jun 18, 2020

Can we add a test to the "found 0 vulnerabilities" audit result?

this will fail due to exogenous reasons all the time and block unrelated PRs unfortunately I think.

@alexcjohnson
Copy link
Contributor

@alexcjohnson alexcjohnson commented Jun 19, 2020

this will fail due to exogenous reasons all the time and block unrelated PRs unfortunately I think.

I guess. Can we put it in noci_test.sh then, so we at least catch any new issues before making a release? It would be a shame to go through all this work and not be able to say future releases are all clean as of their release date. That would still give us the option to release with a known vulnerability if fixing it is more than a small task, but it would be a conscious decision at least.

@archmoj
Copy link
Contributor Author

@archmoj archmoj commented Jun 19, 2020

OK. We could add 'npm audit' step after 'npm ci' to the release checklist.

alexcjohnson
alexcjohnson approved these changes Jun 19, 2020
View changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

OK. We could add 'npm audit' step after 'npm ci' to the release checklist.

That'll do :)

💃

@archmoj archmoj merged commit 665cd7c into master Jun 19, 2020
9 checks passed
@archmoj archmoj deleted the surface-no-cwise branch Jun 19, 2020
@archmoj archmoj mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson

Assignees
No one assigned
Labels
status: reviewable type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security warnings in static-module and minimist
3 participants
@archmoj @alexcjohnson @nicolaskruchten