The Wayback Machine - https://web.archive.org/web/20210928090117/https://github.com/plotly/plotly.js/pull/5175
Skip to content

/ plotly.js Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop period positioning for all histogram traces #5175

Merged
merged 2 commits into from Sep 29, 2020
Merged

Drop period positioning for all histogram traces #5175

merged 2 commits into from Sep 29, 2020

Conversation

@archmoj
Copy link
Collaborator

@archmoj archmoj commented Sep 29, 2020 •
edited

b49da24 addresses #5074 (comment).

1046406 drops (x|y)period* attributes added in #5074 as one could use bin.(start|end|size) instead.

@plotly/plotly_js
@archmoj
fix histogram2dcontour bins in mock
b49da24
@archmoj
drop period positioning for histogram* traces - one could use bin ins…
1046406 
…tead
@archmoj archmoj changed the title Improve labels in histogram2dcontour baseline Drop period positioning for all histogram traces Sep 29, 2020
@archmoj archmoj added this to the v1.56.0 milestone Sep 29, 2020
alexcjohnson
alexcjohnson approved these changes Sep 29, 2020
View changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Fantastic - thanks! 💃

@archmoj archmoj merged commit 38e528e into master Sep 29, 2020
9 checks passed
@archmoj archmoj deleted the fixup-period-mock branch Sep 29, 2020
@archmoj archmoj mentioned this pull request Sep 29, 2020
Merged
@archmoj archmoj mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
v1.56.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@archmoj @alexcjohnson