Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix modebar not recreated when makePlotFramework called #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Yook74! this indeed looks like exactly the right fix The only thing we need now is a test - ideally this would be something like the modebar styling tests - Plotly.plot(gd, data, layout).then(function() {
// test that the initial modebar is present
var modeBar = gd._fullLayout._modeBar;
expect(countGroups(modeBar)).toEqual(6); // whatever buttons should be there
// some modification that would have broken the modebar before your fix:
// react, restyle, click a button... whatever's easiest
return Plotly.react(gd, newData, newLayout);
}).then(function() {
// test that the new modebar is present
var modeBar = gd._fullLayout._modeBar;
expect(countGroups(modeBar)).toEqual(12); // different (nonzero) number of buttons
})
.catch(failTest)
.then(done) |
… different types of plots
|
I wrote tests to catch the particular problem I was having (#4974). |
Thanks for the tests. They pass on my machine. I also re-run the CI tests so that they pass. |
|
Nicely done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #4974
If makePlotFramework was called when updating an existing plot, the modebar div would be cleared, but
gd._fullLayout._modeBarwhich tracks the modebar's state would not be changed. Ifgd._fullLayout._modeBarwas not changed, this conditionalwould update the modebar instead of creating it. Updating the modebar in this context does not work though, since the modebar div has been cleared.
My extremely simple fix is to clear the modebar's state stored in
gd._fullLayout._modeBarwhen clearing the modebar div inmakePlotFramework.