Codecov Report

Merging #3378 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3378   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          95       95           
  Lines        2743     2743           
  Branches      510      510           
=======================================
  Hits         2493     2493           
  Misses        190      190           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0186404...4b2e4cc. Read the comment docs.

@maxokorokov can you please merge this change.

Might be related to this → #1676, need to check in more details.

@maxokorokov
Can you describe the steps required to repeat the problem?
#1615 (comment)
I've looked briefly into MD native date adapter on how to handle the hours (they default to midnight).

@peterblazejewicz nope, not exactly, sorry. But it was something like resetting current timezone to Brazil.

Guys if there is no underlying reason for this change why not revert back to the standard followed by most UI libraries?

Current flow seems like a hack. Moreover, which developer would want to have 12 pm as default, seems really odd.

@maxokorokov Can you please include this in the upcoming datepicker updates.

Can we have some clarity on whether this feature would be included or not?

Kindly share an update on this pull request

Dear Team, kindly merge this pull request to the master repo, or give an attribute through which this can be activated.

@shyamal890 I can't tell you the details because I need to dig up into my memory... But for sure I can tell you (with more than 10 years of JS datepickers implementation expertise) that we must keep noon instead of midnight.

While I am performing the check in my memory, could you please explain me why you absolutely need it ?

@benouat

1. Most (Almost all) including Angular Material sets date to midnight instead of noon.
2. In any type of date selection its expected by the end-user as well as the developer to have it at midnight (also eases saving to database). Having it automatically set to noon is an anti-pattern (Against the norm, developers have to be trained to add one more step to correct it)

@shyamal890 Thanks for your highlights!

I now remember one use case for example, leap second adjustment. If date model is set to midnight, it happens that you are changing day as compared to noon where you don't

And, yes, this is not made up example, I had this issue each single time, and as I told you I have some experience dealing with Javascript Framework ~10 years of various datepicker development)

Did you notice that the NgbDateNativeUTCAdapter is not messing around with the time part of the Date ? Maybe you could simply use that one ?