Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(timepicker): When We Enter 60 in Seconds... are not setting to 0 #3572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3572 +/- ##
==========================================
+ Coverage 91.71% 91.74% +0.03%
==========================================
Files 100 100
Lines 2909 2920 +11
Branches 537 539 +2
==========================================
+ Hits 2668 2679 +11
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
|
As discussed offline together, for me this is not an Angular false positive, and it is not related to change detection. cc @maxokorokov |
gpolychronis
force-pushed the
gpolychronis:fix/3546
branch
2 times, most recently
from
e441343
to
02d42fe
|
As discussed:
|
gpolychronis
force-pushed the
gpolychronis:fix/3546
branch
2 times, most recently
from
4a8878a
to
9b5e392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Attempt to fix #3546 and #3548.
In this case of binding, origin value (model.second) remains the same and destination value (#seconds.input.value) changes. Angular does not correct the destination value, because it detects no change in origin value.
Attempted to fix by forcing the update of destination value.....
@maxokorokov @benouat
Please review