Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(positioning): popper 2 #3671
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
WORK IN PROGRESS - DO NOT MERGE
This is a try on how to handle popper 2 in ngBootstrap. As it's now tree shakable, it's a good candidate for Bootstrap 5.
At the moment, everything seems to work fine. The only issue I was not able to manage is the arrow placement for the popover and tooltip when located on left or right: the arrow is not centered well, I failed to understand why, compared to the examples provided by popper.
Offsets are not managed sharply (I mean, it's not pixel perfect !), but it will be easy to change them through the popper api.