Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updemo(modal): improve explanations on entryComponents #3725
Conversation
entryComponents is not needed anymore since Angular 9. fix #3722
| bootstrap: [NgbdModalComponent], | ||
| entryComponents: [NgbdModalContent] | ||
| bootstrap: [NgbdModalComponent] | ||
| // entryComponents: [NgbdModalContent] // this line would be needed in Angular 8 or older |
pkozlowski-opensource
May 9, 2020
Member
It is more about ivy enabled or not - people can be on v9 and have ivy disabled. This situation will continue for a while (until we remove VE)
It is more about ivy enabled or not - people can be on v9 and have ivy disabled. This situation will continue for a while (until we remove VE)
jnizet
May 9, 2020
Author
Collaborator
Right. I didn't want to be too technical, and simply assume the defaults here. Not sure if all people know what Ivy is and what they're using without knowing it. But I can of course be more precise. How about this?
this line is not needed if Ivy is used (i.e., by default, in Angular 9 or newer)
And the the text in the demo:
In this case, if you're still using ViewEngine (which is the default in Angular 8 or before) remember to add the content component
in the entryComponents section of your NgModule. For Ivy (which is the default in Angular 9 or newer), it's not needed anymore.
Right. I didn't want to be too technical, and simply assume the defaults here. Not sure if all people know what Ivy is and what they're using without knowing it. But I can of course be more precise. How about this?
this line is not needed if Ivy is used (i.e., by default, in Angular 9 or newer)
And the the text in the demo:
In this case, if you're still using ViewEngine (which is the default in Angular 8 or before) remember to add the content component
in theentryComponentssection of yourNgModule. For Ivy (which is the default in Angular 9 or newer), it's not needed anymore.
benouat
Jun 11, 2020
•
Member
What about detailing the text in demo without even referring to ViewEngine or Ivy ?
We could state up to Angular 8 and Angular 9+ ? at least, no confusing, no technical detail... Obviously we could have a detailed section (hidden by default) with a bit more explanation, where we talk about Ivy that can be disabled also in 9+)
What about detailing the text in demo without even referring to ViewEngine or Ivy ?
We could state up to Angular 8 and Angular 9+ ? at least, no confusing, no technical detail... Obviously we could have a detailed section (hidden by default) with a bit more explanation, where we talk about Ivy that can be disabled also in 9+)
|
@jnizet @pkozlowski-opensource jumping into the conversation here I realised several times in the past, and today this PR is no exception, that demos are definitely not the right place to document/describe a feature. Thus, wouldn't it be the right time to introduce the Modal Overview page ? WDYT ? cc @maxokorokov |
entryComponents is not needed anymore since Angular 9.
fix #3722
Before submitting a pull request, please make sure you have at least performed the following: