Codecov Report

Merging #3731 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3731   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files         100      100           
  Lines        2971     2972    +1     
  Branches      548      548           
=======================================
+ Hits         2714     2715    +1     
  Misses        190      190           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea59f88...2d37ec3. Read the comment docs.

Hey @koxkox

I did a first quick pass on your PR, and before continuing, I'd like to address a comment.

What is the actual requirement behind your PR ?
Do you need, visually speaking, to have a label displayed here in your application ?
Is it something related to a11y ? You need a screen reader to read it ?

I am just trying here to understand the change. I am hesitating and not convinced that we should generate it as a standalone text-node as compared to just having an aria-label. Especially that default implementation would be empty string.

Hi @benouat

my goal was to add an option to display the week number column header and also make it localizable, just like the day/month names. The reason I kept it an empty string was to not break the default appearance.