Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow disabling of invalid watchers #91
Merged
Conversation
src/Loop/Driver.php
Outdated
| @@ -134,13 +134,12 @@ | |||
| abstract public function enable($watcherId); | |||
|
|
|||
| /** | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST never fail, | |||
kelunik
Aug 26, 2016
Member
MUST never → MUST NOT
MUST never → MUST NOT
bwoebi
Aug 26, 2016
Author
Member
I've copied from cancel() docs.
I've copied from cancel() docs.
kelunik
Aug 26, 2016
Member
Should probably fixed there as well. Otherwise you might miss the never since only MUST is bold.
Should probably fixed there as well. Otherwise you might miss the never since only MUST is bold.
src/Loop/Driver.php
Outdated
| @@ -134,13 +134,12 @@ | |||
| abstract public function enable($watcherId); | |||
|
|
|||
| /** | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST never fail, | |||
| * even when passed an invalid watcher. | |||
kelunik
Aug 26, 2016
Member
I guess this should be if, not when.
I guess this should be if, not when.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #90.
Following no dissent in the related issue, this should be merged in a few days if nobody else objects.