Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: 6.0 version change file name hash function from md5 to sha256 #3069
Conversation
Insofan
changed the title
codecov
bot
commented
Aug 12, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
- Coverage 83.57% 83.12% -0.46%
==========================================
Files 69 70 +1
Lines 7605 7609 +4
==========================================
- Hits 6356 6325 -31
- Misses 1249 1284 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jonthanon
commented
Aug 12, 2020
|
SHA1 was broken too in 2017, so unfortunately it's insecure as well. The recommendation I'm seeing around is to go to SHA256. |
Insofan
changed the title
From my opinion encrypt file name didn't protect any thing, maybe just helpful for some company's security test. It only just a hash function for generate disk filename, not any cryptographic. |
Insofan commentedAug 12, 2020
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
Change file name hash function from md5 to sha1 (reference issue). Has run test31CachePathForAnyKey and test32CachePathForNilKey.