The Wayback Machine - https://web.archive.org/web/20201115072657/https://github.com/http-party/http-server/issues/588
Skip to content

/ http-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `--tls` option and have `--ssl` be an alias for it #588

Open
thornjad opened this issue Dec 18, 2019 · 3 comments · May be fixed by #640
Open

Make `--tls` option and have `--ssl` be an alias for it #588

thornjad opened this issue Dec 18, 2019 · 3 comments · May be fixed by #640
Labels
good first issue

Comments

@thornjad
Copy link
Member

@thornjad thornjad commented Dec 18, 2019

A small pet peeve of mine is that the --ssl option enables TLS, not SSL. I accept that the tech world uses these related but different terms interchangeably, but I'd rather be more correct by default.

To do:

  1. Replace the existing --ssl option with --tls.
    a. Note that this enables "TLS/SSL" in the documentation so it doesn't confuse people.
    b. The short option -S could stay the same, having it stand for "Secure".
  2. Add back the --ssl option as an alias for --tls.
    a. Note in the documentation that it's an alias
    b. In the code, if ssl is specified, translate it directly into the tls option.
    c. If for some reason the user specifies both options, like --tls --no-ssl, consider --tls to be the authoritative option (i.e. allow the tls option to override ssl).
@ankurkaushal
Copy link

@ankurkaushal ankurkaushal commented Jun 22, 2020

@thornjad: Is this issue still relevant? I have been meaning to get back into OSS & this seemed like an easy win. :)
@thornjad
Copy link
Member Author

@thornjad thornjad commented Jun 29, 2020

Yeah, this is still outstanding, go for it!
@dalgleish dalgleish linked a pull request that will close this issue Jul 18, 2020
Open
1 of 2 tasks complete
@ankurkaushal
Copy link

@ankurkaushal ankurkaushal commented Aug 12, 2020

@thornjad: Looks like @dalgleish already beat me to it. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add --tls option
2 participants
@ankurkaushal @thornjad
You can’t perform that action at this time.