[8.x] Use dynamic app namespace in Eloquent Factory instead of App\ string #35204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
This has been attempted before btw and rejected. In general we don't recommend changing the |
|
I don't get why the Eloquent Factory is using hardcoded namepace and rest of the framework is handling it dynamically. |
taylorotwell
reviewed
Nov 13, 2020
| @@ -626,10 +627,13 @@ public function modelName() | |||
| { | |||
| $resolver = static::$modelNameResolver ?: function (self $factory) { | |||
| $factoryBasename = Str::replaceLast('Factory', '', class_basename($factory)); | |||
| $rootNamespace = Container::getInstance() | |||
| ->make(Application::class) | |||
| ->getNamespace(); | |||
There was a problem hiding this comment.
What if this is called from outside of the Laravel framework?
There was a problem hiding this comment.
As in a Laravel app the Container is implemented by Application would this make sense?
$rootNamespace = method_exists(Container::getInstance(), 'getNamespace')
? Container::getInstance()->getNamespace()
: 'App\\';If it makes sense it could be extracted to a method as it would be needed in more places.
There was a problem hiding this comment.
Didn't see you commit 8bf80de
Guess that is a better solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently, Eloquent Factory does not handle model namespaces other than the ones with
App\prefix.(This is the only place in the framework where
App\string is used, all the other parts are usinggetNamespace()fromApplication.)This PR eliminates the use of
App\namespace string and adds a dynamic way to determine the actual root namespace.Test is included.