Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove strict mode #676
Merged
Remove strict mode #676
Conversation
|
See also (and please improve) https://github.com/go-sql-driver/mysql/wiki/strict-mode |
|
LGTM. Nice simplification. |
dsn.go
Outdated
| if !isBool { | ||
| return errors.New("invalid bool value: " + value) | ||
| } | ||
| return errors.New("strict mode has been removed. See https://github.com/go-sql-driver/mysql/wiki/strict-mode") |
julienschmidt
Sep 30, 2017
Author
Member
Should this panic?
Should this panic?
scottjg
added a commit
to scottjg/mysql-driver
that referenced
this pull request
Oct 3, 2017
It was removed from the upstream mysql package in go-sql-driver/mysql#676
This was referenced Oct 5, 2017
fho
added a commit
to simplesurance/migrate
that referenced
this pull request
Oct 27, 2017
compilation failed with: driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings MySQLWarnings was removed from the mysql driver (go-sql-driver/mysql#676), remove it from migrate
fho
added a commit
to simplesurance/migrate
that referenced
this pull request
Oct 27, 2017
compilation failed with: driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings MySQLWarnings was removed from the mysql driver (go-sql-driver/mysql#676), remove it from migrate
fho
added a commit
to simplesurance/migrate
that referenced
this pull request
Oct 27, 2017
compilation failed with: driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings MySQLWarnings was removed from the mysql driver (go-sql-driver/mysql#676), remove it from migrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
We know for a while already that our strict mode can cause a lot of problems and is not safe to use. See #556 #602 #635
A proper server-side mode should be set instead of this driver-side hack.
This PR removes the strict mode completely.
Checklist