The Wayback Machine - https://web.archive.org/web/20201020110437/https://github.com/go-sql-driver/mysql/pull/995
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NullTime as go1.13's sql.NullTime #995

Merged
merged 3 commits into from Sep 5, 2019

Conversation

@dolmen
Copy link
Contributor

@dolmen dolmen commented Sep 4, 2019

Description

Refactor type mysql.NullTime to be forward binary compatible (so cast-compatible) with Go 1.13's database/sql.NullTime.

sql.Scanner MySQL specific implementation is preserved.

Somewhat related to #960.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing on go1.12.9 and go1.13
  • Extended the README / documentation, if necessary
  • Already in the AUTHORS file
Copy link
Member

@julienschmidt julienschmidt left a comment

Looks good. Thanks!

@julienschmidt julienschmidt added the Go1.13 label Sep 4, 2019
@julienschmidt julienschmidt added this to the v1.5.0 milestone Sep 4, 2019
@methane
Copy link
Member

@methane methane commented Sep 5, 2019

Looks very nice idea.

@methane methane merged commit d9aa6d3 into go-sql-driver:master Sep 5, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 81.093%
Details
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.