The Wayback Machine - https://web.archive.org/web/20201211004919/https://github.com/github/backup-utils/issues/296
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check target disk space before attempting restore #296

Open
adamcharlton opened this issue Apr 3, 2017 · 3 comments
Open

Check target disk space before attempting restore #296

adamcharlton opened this issue Apr 3, 2017 · 3 comments

Comments

@adamcharlton
Copy link

@adamcharlton adamcharlton commented Apr 3, 2017

Hi, I encountered an issue where my restore failed due to insufficient disk space on the restore target.

When running the restore on Linux an error like rsync: writefd_unbuffered failed to write 4 bytes to socket [sender]: Broken pipe (32) occurs however on a Mac you do not get an error at all and it just stalls until you close the restore process.

I think it would be nice if the restore calculated the size of the restore about to happen and verified that the /data/user directory on the target had sufficient space for the restore, as this would provide instant feedback that the restore would not be successful.

@rubiojr
Copy link
Member

@rubiojr rubiojr commented Apr 3, 2017

@adamcharlton: makes sense. Should be easy to implement for single VM restores.

@rubiojr
Copy link
Member

@rubiojr rubiojr commented Apr 3, 2017

@adamcharlton out of curiosity, which macOS/rsync version are you using?

@rubiojr
Copy link
Member

@rubiojr rubiojr commented Apr 3, 2017

@adamcharlton we've been discussing this internally. The TL;DR is that estimating if there's enough free disk space available is complicated and/or expensive because we compress some data that has to be expanded remotely. We're looking into better error reporting for now, so the cryptic rsync error isn't the only thing you get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.