The Wayback Machine - https://web.archive.org/web/20201015111442/https://github.com/rsuite/rsuite/pull/1300
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-router.md #1300

Open
wants to merge 1 commit into
base: next
from
Open

Update with-router.md #1300

wants to merge 1 commit into from

Conversation

@u1tima
Copy link

@u1tima u1tima commented Sep 22, 2020

Use Nav with Link in react-router

@vercel
Copy link

@vercel vercel bot commented Sep 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rsuite/rsuite/o7jhh0faf
Preview: Failed

@simonguo simonguo changed the base branch from next to v4 Sep 23, 2020
@simonguo simonguo changed the base branch from v4 to next Sep 23, 2020
@simonguo
Copy link
Member

@simonguo simonguo commented Sep 23, 2020

@u1tima
The next branch is a branch that is still in the development stage of the V5 version.
The PR you submit should be updated to the v4 branch. And there are two files that need to be updated simultaneously.

https://github.com/rsuite/rsuite/blob/v4/docs/pages/components/nav/en-US/with-router.md
https://github.com/rsuite/rsuite/blob/v4/docs/pages/components/nav/zh-CN/with-router.md

@simonguo
Copy link
Member

@simonguo simonguo commented Sep 23, 2020

import Link from 'next/link';
export default function Page() {
return (
<DefaultPage
examples={[
'basic',
'appearance',
'vertical',
'status',
'justified',
'dropdown',
'icon',
'with-router',
'responsive-nav',
'removable-nav'
]}
dependencies={{ Nav, Button, Icon, Dropdown, Row, Col, Slider, ResponsiveNav, Link }}

I found that this guide example should not be changed. The Link used in the example is Link in next/Link instead of Link in react-router.

The guide is wrong in the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.