The Wayback Machine - https://web.archive.org/web/20201117185426/https://github.com/eventflow/EventFlow/pull/676
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added event persistence implementation for StreamsDb #676

Open
wants to merge 11 commits into
base: develop
from

Conversation

@promontis
Copy link
Contributor

@promontis promontis commented Sep 2, 2019

@pjvds could you review and add a test

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Sep 2, 2019

CLA assistant check
All committers have signed the CLA.

@promontis promontis changed the base branch from master to develop Sep 2, 2019
@rasmus rasmus changed the title Added event persistence implementation for StreamsDb WIP: Added event persistence implementation for StreamsDb Sep 3, 2019
@rasmus rasmus added the enhancement label Sep 3, 2019
@rasmus
Copy link
Member

@rasmus rasmus commented Sep 3, 2019

The tests should as a minimum use TestSuiteForEventStore to make sure that the basics are covered.

@pjvds
Copy link

@pjvds pjvds commented Sep 6, 2019

@promontis First of all, thanks for making the effort to write an event store implementation on top of StreamsDB. Very much appreciated!

I've created a pull request that introduces the test project in your fork. This test project is based on the suggestion of @rasmus (thanks for the awesome test set!).

The pull request also has some fixes. If you accept my pull request on your fork, you can test drive the StreamsDB event store in your project.

My pull request updates your develop branch, since EventFlow uses that branch as the trunk. So I would suggest you update this pull request to reflect that change.

See: promontis#1

@pjvds
Copy link

@pjvds pjvds commented Sep 6, 2019

The are still 3 things left to do:

  • Support stream deletes (this is blocked by the current beta release of StreamsDB)
  • Add readme and example to the EventFlow.EventStore.StreamsDB project
  • Add the test project to the CI build
promontis added 8 commits Sep 7, 2019
Added CursorsStream to ReadModuleUpdate poco
Working test, but still need to add transaction when psa is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.