Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Make serialization scheme more generic #760
Conversation
|
|
…set serialiaztion scheme (string)
Add support for serialization schemes with snapshot stores Set generic constraint on TSerialized (parameter must implement IEnumerable, such as string and byte[])
|
Hi @rasmus, looks like this PR is ready for review (AppVeyor is still running at the moment). |
|
@rasmus looks like appveyor timed out, can you restart the build please? |
|
@rasmus the appveyor build timed out again (after 1 hour). Does this happen more often? Can you see more details maybe on what causes it to time out? |
|
Normally it doesn't, I'll have a look this evening |
|
Usually its the RabbitMQ tests that die, this seems a bit odd. |
|
While I do like the cleanup, this change has several braking changes thus we'll have to wait until a major release. While 0.x is technically a beta version, many rely in the current APIs and I try not to do any API breaking changes. I know that there are plenty companies out there that have implemented their own event store to better suit their infrastructure. |
At the moment, quite a few implementation in the library are tightly coupled to JSON de/serialization.
For my current project, I need to use a more compact binary serialized scheme.
This PR makes event serialization scheme more generic, and allows for dropping in binary serialization.
This adds support for using for example Protobuf of BSON serialization of events.