The Wayback Machine - https://web.archive.org/web/20201117190909/https://github.com/eventflow/EventFlow/pull/800
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF: save all events in one comimt #800

Open
wants to merge 1 commit into
base: develop
from

Conversation

@pawelsie
Copy link

@pawelsie pawelsie commented Oct 29, 2020

This will reduce number of calls to DB when aggregate have more that one event to store.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 29, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

@codecov codecov bot commented Oct 29, 2020

Codecov Report

Merging #800 into develop will increase coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #800      +/-   ##
===========================================
+ Coverage    72.35%   72.46%   +0.11%     
===========================================
  Files          338      338              
  Lines         8533     8532       -1     
  Branches      2571     2571              
===========================================
+ Hits          6174     6183       +9     
+ Misses        1474     1467       -7     
+ Partials       885      882       -3     
Impacted Files Coverage Δ
...ork/EventStores/EntityFrameworkEventPersistence.cs 87.17% <50.00%> (-2.70%) ⬇️
...Flow.MongoDB/EventStore/MongoDbEventPersistence.cs 59.25% <0.00%> (-12.97%) ⬇️
...urce/EventFlow.Sql/ReadModels/SqlReadModelStore.cs 76.14% <0.00%> (-4.59%) ⬇️
...ntFlow.MongoDB/ReadStores/MongoDbReadModelStore.cs 79.26% <0.00%> (-1.22%) ⬇️
...icsearch/ReadStores/ElasticsearchReadModelStore.cs 53.63% <0.00%> (+3.63%) ⬆️
...ngoDB/SnapshotStores/MongoDbSnapshotPersistence.cs 96.07% <0.00%> (+9.80%) ⬆️
Source/EventFlow/Jobs/JobRunner.cs 66.66% <0.00%> (+11.11%) ⬆️
...l/SnapshotStores/PostgresSqlSnapshotPersistence.cs 80.32% <0.00%> (+13.11%) ⬆️
Source/EventFlow/Exceptions/UnknownJobException.cs 75.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f24ec...f453894. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.