The Wayback Machine - https://web.archive.org/web/20200915204901/https://github.com/chromium/badssl.com/pull/389
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions in Dockerfile #389

Open
wants to merge 1 commit into
base: master
from
Open

Fix permissions in Dockerfile #389

wants to merge 1 commit into from

Conversation

@christhompson
Copy link
Collaborator

christhompson commented Jun 12, 2019

When working on #388, running make serve led to nginx throwing lots of permission errors. This adds an extra command run before the main entrypoint in Dockerfile to ensure that all assets in /var/www/badssl are readable by nginx. This should make the testing server a little more robust.

@christhompson christhompson requested a review from april Jun 12, 2019
@christhompson
Copy link
Collaborator Author

christhompson commented Jul 10, 2019

@april Does this look good to you? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.