The Wayback Machine - https://web.archive.org/web/20201112101706/https://github.com/playframework/playframework/pull/10411
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update akka-http-core, akka-http2-support to 10.2.0 #10411

Open
wants to merge 1 commit into
base: master
from

Conversation

@scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Aug 6, 2020

Updates

from 10.1.12 to 10.2.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe.akka" } ]
Applied Migrations

Documentation:

labels: library-update, semver-minor, scalafix-migrations

Copy link
Contributor

@ennru ennru left a comment

This should be spared for the next minor version.

@raboof
Copy link
Member

@raboof raboof commented Aug 18, 2020

This should be spared for the next minor version.

master is the upcoming 2.9, so that would just mean 'not backporting to 2.8.x', right?

@mkurz
Copy link
Member

@mkurz mkurz commented Aug 18, 2020

master is the upcoming 2.9, so that would just mean 'not backporting to 2.8.x', right?

Exactly.

@raboof
Copy link
Member

@raboof raboof commented Aug 18, 2020

Nonetheless there's something to be said for holding back bigger changes to master to reduce conflicts while backporting important smaller changes - WDYT?

@mkurz
Copy link
Member

@mkurz mkurz commented Aug 18, 2020

Nonetheless there's something to be said for holding back bigger changes to master to reduce conflicts while backporting important smaller changes - WDYT?

I have a feeling that we have never really held back changes/features to master just to make backporting smaller changes easier... I think the way to go is to just hack on master, no matter what. That's how we did it the last years and I think it worked out well. I mean, when would you start adding "bigger changes" to master then? Splitting big changes into smaller commits helps backporting anyway.
Personally I would not hold back anything from master just because of backports.

@mergify mergify bot added the type:updates label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.