Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
[2.7.x] Let user overwrite limit memory size on form binding #10543
+178
−40
Conversation
(cherry picked from commit 5c031b6)
ignasi35
changed the title
Closed
| @@ -738,11 +744,12 @@ trait PlayBodyParsers extends BodyParserUtils { | |||
| ): BodyParser[A] = | |||
| BodyParser { requestHeader => | |||
| import play.core.Execution.Implicits.trampoline | |||
| val parser = anyContent(maxLength) | |||
| val parser = anyContent(maxLength) | |||
| val binding = formBinding(maxLength.getOrElse(DefaultMaxTextLength)) | |||
ignasi35
Nov 23, 2020
Author
Member
val binding = formBinding(maxLength.getOrElse(DefaultMaxTextLength)) is necessary to honour the maxLenght provided on this method.
val binding = formBinding(maxLength.getOrElse(DefaultMaxTextLength)) is necessary to honour the maxLenght provided on this method.
|
LGTM Left some minor suggestions on migration page. |
documentation/manual/releases/release27/migration27/Migration27.md
Outdated
Show resolved
Hide resolved
documentation/manual/releases/release27/migration27/Migration27.md
Outdated
Show resolved
Hide resolved
documentation/manual/releases/release27/migration27/Migration27.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Renato Cavalcanti <[email protected]>
ignasi35
force-pushed the
ignasi35:let-user-overwrite-limit-size-take-two
branch
from
8bba039
to
ece858a
|
I didn't follow this pull request, but is this something that should be forward ported to master/2.8.x? |
|
yes, we will forward port it. |
|
I fixed some typos which sneaked into this pull request: #10547 |
ignasi35
added a commit
to ignasi35/playframework
that referenced
this pull request
Dec 3, 2020
Co-authored-by: Renato Cavalcanti <[email protected]> Co-authored-by: Will Sargent <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2020
Co-authored-by: Renato Cavalcanti <[email protected]> Co-authored-by: Will Sargent <[email protected]> (cherry picked from commit cebb701) # Conflicts: # project/BuildSettings.scala
|
Hey peeps, micro feedback that this broke a few hundred of bindings for us, since we've been providing the implicit manually: All good, a simple new implicit resolved this, but in case you want to provide the old signature for backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Improves #10496 to avoiding using a hardcoded memory limit when binding a request to a form.
Supersedes #10534 and #10539
This PR puts together ideas and code previously pushed to #10534 and #10539 with some extra feedback from offline discussions.