Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Implement driver for CockroachDB #1164
Comments
@ovr I would like to work on this issue. I see that Cockroach DB fully supports the Postgres JDBC driver(https://www.cockroachlabs.com/docs/stable/install-client-drivers.html#java). So planning to add JDBC config for the same. Do let me know your thoughts. Thanks! |
Hello Ronan D'Souza, The JDBC driver is outdated and ignored on our CI because it's working on Node.js <= 8. It requires migration from one JDBC vendor to another because the current one is outdated and not supported.
It's not the only thing that should be done to support CockroachDB. Each driver requires a dialect for SQL. Implementing a "native" driver is a more useful and stable solution that we should choose. |
Thanks for your feedback, Dmitry. Since cockroachDB supports Postgres clients, I tried connecting to a cockroachDB using the Postgres driver in cube.js. I found that it partly works. For some reason, this query returns an SQL syntax error Will also try exploring the native driver route. |
Driver contains SQL dialect. It's a bad idea to use PostgreSQL Dialect with CockroachDB. Take a look at |
Hey!
Currently, there are no plans to add support for it (from core team), but we are happy to merge and help with contribution from the community.
For driver implementer, take a look at
https://github.com/cube-js/cube.js/blob/master/CONTRIBUTING.md#implementing-sql-dialect
Example of driver implementation
#1099
Who are interested in preparing PR, don't forget to comment this issue
Thanks