local scope variables are not available inside rescue_from #1922

aruprakshit · 2019-10-23T07:48:57Z

I have current_user defined inside the before hook, and then we try to read it from rescue_from method, we get nil.

before do
  token         = nil
  token         = headers.fetch("Authorization", "").split("Basic ")[1] unless report_url?
  @current_user = ::User.find_by(auth_token: token) if token.present?

  PaperTrail.request.whodunnit = @current_user.id if @current_user
end

helpers Pundit

helpers do
  attr_reader :current_user

  def report_url?
    request.path_info == "/v1/share_reports/#{request.params['token']}"
  end

  # ....
end


rescue_from Pundit::NotAuthorizedError do |e|
  Airbrake.notify(e, {
    user: {
      id: current_user.id,
      email: current_user.email
    }
  })

  error!(
    {
      messages: {
        userNotification: e.message
      }
    }, 401
  )
end

We get nil error when current_user being accessed inside the rescue_from block as current_user.id. How can I make available current_user inside the rescue_from block?

Gemfile

gem "rails", "5.2.3"
gem 'grape', '~> 1.0'
gem 'grape-entity', '~> 0.7.1'

The text was updated successfully, but these errors were encountered:

dblock · 2019-10-23T14:10:54Z

I think I'd want this to work. Doing @something = in before makes it available in the execution of the API (we made that work a long time ago), but not in rescue_from. Let's call it a bug or a non-feature. Maybe someone could try to fix it?

As a workaround, the rescue block is not executed in the same scope as the request, so you don't have access to attributes. You do have access to context (since #1918, in a released version you can reach into ENV), which gives you the endpoint and then gives you endpoint-based context and settings. I think you generally want to do what Warden does, which is using ENV to pass around something across various contexts of the request (before, during, after) and not @.

aruprakshit · 2019-10-23T17:26:06Z

@dblock For now I worked it around in my code by following this merged code. But once, it will be released I think I can use context.

current_user is available when I do access it like below inside the helpers block.

def signed_in_user
  # check https://github.com/ruby-grape/grape/pull/1918/files
  # We will remove it, once the grape 1.5 is released.
  env[Grape::Env::API_ENDPOINT].current_user
end

dblock · 2019-10-23T19:53:51Z

Yep. I will leave this open to make @variable work. At the very least we should document what the scope of @ is in a rescue_from block.

@aruprakshit This is a good place for someone to write some tests and contribute :) Wink wink

dblock added the bug? label Oct 23, 2019

dblock added the feature request label Oct 23, 2019

dblock changed the title ~~helpers are not available inside the rescue_from block - Why?~~ local scope variables are not available inside rescue_from Oct 23, 2019

Dec	JAN	Feb
	06
2020	2021	2022

ruby-grape / grape

local scope variables are not available inside rescue_from #1922

local scope variables are not available inside rescue_from #1922

aruprakshit commented Oct 23, 2019 •

edited

dblock commented Oct 23, 2019 •

edited

aruprakshit commented Oct 23, 2019

dblock commented Oct 23, 2019

ruby-grape / grape

Sponsor ruby-grape/grape

local scope variables are not available inside rescue_from #1922

local scope variables are not available inside rescue_from #1922

Comments

aruprakshit commented Oct 23, 2019 • edited

Gemfile

dblock commented Oct 23, 2019 • edited

aruprakshit commented Oct 23, 2019

dblock commented Oct 23, 2019

aruprakshit commented Oct 23, 2019 •

edited

dblock commented Oct 23, 2019 •

edited