Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Python 3.9 #3926
Python 3.9 #3926
Conversation
|
My strong preference would be that this repo migrates to the current version of Python and leave the following algorithms out of our test cycle because their dependencies do not yet support Python 3.9. I would much rather ensure that our code is tested on and compatible with the current Python than to continue to wait. Six+ weeks is long enough especially given CPython's long alpha, beta, release candidate cycle. Note: The following files do not have
|
I am a bit hesitant to do monkey patching on an entire repository as that might lead to an unforeseen situation in the future. Also, not everyone is going to have the latest Python installed on their machine let alone use it. On a side note, any idea as to why the test is taking 18 minutes to download the dependecies? |
I do not think that changing the file extension on four files constitutes monkey patching on an entire repository. The build times are about the lack of wheels on some dependencies. Does your build cache help us to resolve that issue or will we always have long builds? |
Try pushing an empty commit and we will check but even without cache it shouldn't take this much time. |
Closing and reopening the pull request to trigger workflow runs. |
Pip process is 3 minutes with caching... I can live with that. |
There's some problem with the wheels of |
Let's restrict |
Well then we don't need to restrict |
Running on Python 3.9 is different than having a wheel for Python 3.9. The former means that it does not work. The latter means that it works but the install time is long. The tests for all of our quantum algorithms run and pass on Python 3.9. The long install times are dealt with by your pip cache. |
Describe your change:
Migrate to Python 3.9 changing the file extensions of all files that require TensorFlow.
Checklist:
Fixes: #{$ISSUE_NO}
.