Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Guiding people using contibuting.md so they do not fail pre-commit #3887
Comments
Pre-commit pluginTo forget about coding style and let pre-commit fix your
That's it! |
that seems to look good, almost 70% percent of pull request I see fails pre-commit which was hard to fix manually until i came to know we can use this locally to make changes |
hey , @dhruvmanila i would Love to work on this issue . |
Well @Joe-Sin7h, You can start working and link this issue in your PR. No need to get assigned |
1flake8/ isort/ black. Instalar el compromiso previo: $ python -m pip install pre-commit |
wget https://public.dhe.ibm.com/aix/freeSoftware/aixtoolbox/RPMS/ppc-6.1/gcc/libgcc-6.3.0-2.aix6.1.ppc.rpm Instalar el compromiso previo: $ python -m pip install pre-commit |
pre-commit --versiflake8/ isort/ black. Instalar el compromiso previo: $ python -m pip install pre-commit |
Sorry, We understand english |
Hello, I have made the necessary changes in CONTRIBUTING.md, and I am getting the following error when I try to commit the changes: |
Sure, You should try the steps yourself (Warning: they are steps for you only, complete steps have been mentioned above):
|
Also, retry the whole procedure of commiting, and then upload the |
Hello @xcodz-dot The last pre-commit test i.e. Validate filenames is failing with the following error: The pre-commit.log is mentioned below:
error information
` |
It seems something is trying to open the python executable |
I recommend for you to try the official python setup instead of windows app. |
Tried everything, The final step is still failing. @xcodz-dot |
Try running this command in root of repo instead of old one, also post your command line and log again after this:
|
It is the root of the repository. i.e. |
Ok try the commands |
@xcodz-dot The following lines are from cmd after running the commands mentioned by you:
|
Now please post me the log |
The log is mentioned below: version information
error information
|
try: I can't help much cause the issue is with internal working |
@xcodz-dot I tried to commit using WSL, any idea that why is it looking for shebang and how to fix that?
I tried to remove the executable permissions of contributing.md by |
how about trying |
Also, which editor are you using? |
You can try raising this issue in pre-commit repo, they might help you out |
I have a simple instruction which is good to be kept in CONTRIBUTION.md. Please add this wherever it looks good:
pip install pre-commit
pre-commit run --all-files